Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication chat test scenario remove participant - updated the error code in comment #7728

Merged

Conversation

v-vprasannak
Copy link
Contributor

Communication chat test scenario remove participant - updated the error code in comment


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Hi @v-vprasannak,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

azure-client-tools-bot-prd bot commented Jun 19, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jun 19, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 19, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

⚠️ Release Suggestions

Module: communication

  • Update VERSION to 1.9.4 in src/communication/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@@ -265,7 +265,7 @@ def test_chat_remove_participants(self, communication_resource_info):
self.cmd('az communication chat participant remove --thread {thread_id} --user {user_id} --yes')

# assert 'The initiator doesn\'t have the permission to perform the requested operation.' in str(raises.exception)
# For now rest endpoint returns a 500 error, so we are checking for that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary to release a new version if only the test code changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kairu-ms, reverted the version upgrade changes

@kairu-ms kairu-ms merged commit 78867bf into Azure:main Jul 1, 2024
17 checks passed
liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
…or code in comment (Azure#7728)

* Communication chat test scenarion remove participant - updated the error code in comment

* Communication - updated version and history files

* Revert "Communication - updated version and history files"

This reverts commit 64e4775.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. skip-cal-version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants